support custom URL parameters in a GetLegendGraphic request for a layer without a style configured #7263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er without a style configured
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #7198
This PR addresses aforementioned issue by reusing an existing constant
QUERY_PARAMETERS_TO_REMOVEto create a base URL for a legendGraphic request. I've added a new getter onWebMapServiceCatalogItemso the getter can be reused in the future.Test me
A unit test is added to test this behaviour. The new test was failing before I applied the proposed change.
Manual testing:
The 'before' situation can be viewed with this ci.terria.io link. If one:
After adding the layer, the legendGraphic fails to load in the 'before' situation.
This gist can be used in testing the 'after' situation. When adding aforementioned layer, the legend graphic should be visible. I've tried to prepare an 'after' test by using ci.terria.io, but I think I can only use this method with branches existing on the official terriajs repo? If not, I would love to know how to create a ci.terria.io link with a branch from a forked repo.
Checklist
doc/.